Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 3.0.0 manifest to use JDK-21 #4182

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Update 3.0.0 manifest to use JDK-21 #4182

merged 1 commit into from
Oct 30, 2023

Conversation

reta
Copy link
Contributor

@reta reta commented Oct 30, 2023

Description

Update 3.0.0 manifest to use JDK-21

Issues Resolved

Part of #4071

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Merging #4182 (4cc94a2) into main (44a68e4) will decrease coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4182      +/-   ##
==========================================
- Coverage   93.31%   93.29%   -0.03%     
==========================================
  Files         187      187              
  Lines        5792     5802      +10     
==========================================
+ Hits         5405     5413       +8     
- Misses        387      389       +2

see 1 file with indirect coverage changes

@rishabh6788
Copy link
Collaborator

@reta I can see TestReleaseNotesCheck failing as it is now expecting jdk-21 instead of jdk-20.
In your workspace can you please run below and check-in the updated files.

./gradlew clean
./gradlew test -info -Ppipeline.stack.write=true --tests=TestReleaseNotesCheck

@reta
Copy link
Contributor Author

reta commented Oct 30, 2023

@reta I can see TestReleaseNotesCheck failing as it is now expecting jdk-21 instead of jdk-20.

Thanks a lot for the hint, @rishabh6788 !

@rishabh6788
Copy link
Collaborator

I believe @peterzhuamazon is taking care of deploying new jenkins agent AMIs with jdk-21.
He will be approving and merging this once everything is in place.

@peterzhuamazon peterzhuamazon merged commit b3086ff into opensearch-project:main Oct 30, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhuamazon peterzhuamazon peterzhuamazon approved these changes

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@bbarani bbarani Awaiting requested review from bbarani

@gaiksaya gaiksaya Awaiting requested review from gaiksaya gaiksaya is a code owner

@rishabh6788 rishabh6788 Awaiting requested review from rishabh6788 rishabh6788 is a code owner

@zelinh zelinh Awaiting requested review from zelinh zelinh is a code owner

@jordarlu jordarlu Awaiting requested review from jordarlu

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

@Divyaasm Divyaasm Awaiting requested review from Divyaasm Divyaasm is a code owner

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

Assignees
No one assigned
Labels
seasoned-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reta @rishabh6788 @peterzhuamazon